[FFmpeg-devel] [PATCH] avformat/mov: Fix integer overflows related to sample_duration

Michael Niedermayer michael at niedermayer.cc
Mon Mar 12 01:58:48 EET 2018


On Sat, Mar 10, 2018 at 10:48:16PM +0100, Michael Niedermayer wrote:
> Fixes: runtime error: signed integer overflow: -9166684017437101870 + -2495066639299164439 cannot be represented in type
> 
> Fixes: Chromium bug 791349
> 
> Reported-by: Matt Wolenetz <wolenetz at google.com>
> Reviewed-by: Matt Wolenetz <wolenetz at google.com>
> Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> ---
>  libavformat/mov.c | 20 +++++++++++++++-----
>  1 file changed, 15 insertions(+), 5 deletions(-)

applied

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180312/ee1ddc2a/attachment.sig>


More information about the ffmpeg-devel mailing list