[FFmpeg-devel] avcodec/hapqa_extract_bsf : add bsf filter for haqqa (to hapq or hapalpha only) conversion

[Martin Vignali]

Hello,

Thanks for the comments.

> +
> > +    av_log(bsf, AV_LOG_DEBUG, "Texture to keep : %d.\n", ctx->texture);
>
> There's no point printing this on every packet. Either add an init()
> callback function and put it there, or remove it altogether since it's
> of dubious usefulness.
>

Removed.


>
>
> > +    ret = av_new_packet(out, target_packet_size);
> > +    if (ret < 0)
> > +        goto fail;
> > +
> > +    out_buf = out->data;
> > +    bytestream_put_buffer(&out_buf, in->data + start_section_size,
> target_packet_size);
> > +
> > +    ret = av_packet_copy_props(out, in);
> > +    if (ret < 0)
> > +        goto fail;
>
> Why not just do something like
>
> av_packet_move_ref(out, in);
>
> out->data += start_section_size;
> out->size  = target_packet_size;
>

Work for me, changed.

New patchs in attach, with these changes.

Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-avcodec-hap-move-parse_section_header-to-hap.c-in-or.patch
Type: application/octet-stream
Size: 4879 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180311/09e04f3e/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-avcodec-hapqa_extract_bsf-add-new-bsf-filter.patch
Type: application/octet-stream
Size: 6718 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180311/09e04f3e/attachment-0001.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-doc-bsf-add-doc-for-new-hapqa_extract-bsf-filter.patch
Type: application/octet-stream
Size: 1400 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180311/09e04f3e/attachment-0002.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-changelog-add-entry-for-hapqa-extract-bsf.patch
Type: application/octet-stream
Size: 630 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180311/09e04f3e/attachment-0003.obj>