[FFmpeg-devel] [PATCH v3 0/2] libavfilter/vf_fps: Rewrite using activate callback

Nicolas George george at nsup.org
Thu Mar 8 12:35:39 EET 2018

Calvin Walton (2018-02-22):
> This revision of the patch fixes statistics by counting the number of
> times each frame has been output, rather than trying to guess at the
> time each frame is output whether it was a duplicate or drop.
> I ended up leaving the conditional check
>     if (s->status && s->frames_count == 0) {
> at the bottom of the activate function. I think I agree that the
> condition will always be true, based on the code flow, but the if
> statement documents the condition just as well as an assert would, and
> it's not like the EOF handling is in a hot path where we'd want to
> compile out the check.
> Calvin Walton (2):
>   libavfilter/vf_fps: Rewrite using activate callback
>   libavfilter/vf_fps: Minor cleanups
>  libavfilter/vf_fps.c | 392 ++++++++++++++++++++++++++-------------------------
>  1 file changed, 202 insertions(+), 190 deletions(-)

I just pushed. Thanks for the patch and sorry for the delay.


  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180308/fd8d295a/attachment.sig>

More information about the ffmpeg-devel mailing list