[FFmpeg-devel] [PATCH 1/2] avformat/utils: free existing extradata before trying to allocate a new one

James Almer jamrial at gmail.com
Tue Mar 6 06:42:36 EET 2018


This prevents leaks in the rare cases the function is called when extradata
already exists.

Signed-off-by: James Almer <jamrial at gmail.com>
---
 libavformat/utils.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/libavformat/utils.c b/libavformat/utils.c
index 72531d4185..31340a484b 100644
--- a/libavformat/utils.c
+++ b/libavformat/utils.c
@@ -3245,6 +3245,7 @@ int ff_alloc_extradata(AVCodecParameters *par, int size)
 {
     int ret;
 
+    av_freep(&par->extradata);
     if (size < 0 || size >= INT32_MAX - AV_INPUT_BUFFER_PADDING_SIZE) {
         par->extradata = NULL;
         par->extradata_size = 0;
-- 
2.16.2



More information about the ffmpeg-devel mailing list