[FFmpeg-devel] [PATCH] frame: add an av_frame_new_side_data_from_buf function

[Rostislav Pehlivanov]

On 1 March 2018 at 19:19, James Almer <jamrial at gmail.com> wrote:

> On 3/1/2018 3:58 PM, Rostislav Pehlivanov wrote:
> > Also fixes a theoretical memory leak in av_frame_new_side_data_from_buf
> > where if ret was successfully allocated but the realloc call failed,
> > ret wouldn't be freed.
>
> Currently, if realloc fails, ret is never allocated to begin with.
>
> There's no leak at all in any circumstances right now. That change
> you're trying to make is unnecessary.
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>

I see what you mean, I don't remember why I moved that back in November.

Pushed, thanks for the reviews