[FFmpeg-devel] [PATCH]ffplay: Don't crash if stream_cycle_channel() is called before initialization

Carl Eugen Hoyos ceffmpeg at gmail.com
Wed Jun 20 23:44:44 EEST 2018


2018-06-20 22:43 GMT+02:00, Marton Balint <cus at passwd.hu>:
>
>
> On Mon, 11 Jun 2018, Marton Balint wrote:
>
>>
>>
>> On Mon, 11 Jun 2018, Carl Eugen Hoyos wrote:
>>
>>> Hi!
>>>
>>> Attached patch fixes a crash if SDL sends a keydown event before
>>> stream and window initialization is finished, ticket #7252.
>>
>> Wow, current ffplay code assumes that no keypress or mouse events will
>> come
>> before the window is shown. Strange thing that SDL2 on IOS is forwarding
>> input events even without a window...
>>
>> So in order to fix this more thoroughly, I suggest the attached patch
>> instead. Supporting keypresses without a window (e.g. -nodisp mode) might
>> be
>> possible, but that requires bigger changes...
>
> Pushed.

Thank you!

Carl Eugen


More information about the ffmpeg-devel mailing list