[FFmpeg-devel] [PATCH]ffplay: Don't crash if stream_cycle_channel() is called before initialization

Marton Balint cus at passwd.hu
Tue Jun 12 00:31:12 EEST 2018



On Mon, 11 Jun 2018, Carl Eugen Hoyos wrote:

> Hi!
>
> Attached patch fixes a crash if SDL sends a keydown event before
> stream and window initialization is finished, ticket #7252.

Wow, current ffplay code assumes that no keypress or mouse events will 
come before the window is shown. Strange thing that SDL2 on IOS 
is forwarding input events even without a window...

So in order to fix this more thoroughly, I suggest the attached patch 
instead. Supporting keypresses without a window (e.g. -nodisp mode) might 
be possible, but that requires bigger changes...

Regards,
Marton
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-ffplay-ignore-keypress-events-before-a-window-is-cre.patch
Type: text/x-patch
Size: 1609 bytes
Desc: 
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180611/432188df/attachment.bin>


More information about the ffmpeg-devel mailing list