[FFmpeg-devel] [PATCH v1 00/11] Replace magic number by micro for bprint init

mypopy at gmail.com mypopy at gmail.com
Mon Jun 11 03:48:34 EEST 2018


On Sun, Jun 10, 2018 at 5:28 PM Nicolas George <george at nsup.org> wrote:
>
> Jun Zhao (2018-06-10):
> > v1: - Replace magic number by micro for bprint init
>
> I will not oppose the patch series, but I think it is useless clutter of
> the history. The special values are not magic, they are logical or
> standard.
How about change the commit message with "Replace the number by micro
for code  code readability"?
>
> But if anybody applies this, please fix the typo in the commit messages.
>
> Regards,
>
> --
>   Nicolas George
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel



-- 
=======================================
Jun zhao/赵军
+++++++++++++++++++++++++++++++++++++++


More information about the ffmpeg-devel mailing list