[FFmpeg-devel] [PATCH] configure: fix inline neon regression

John Cox jc at kynesim.co.uk
Thu Jun 7 13:49:55 EEST 2018


Hi

This patch fixes the regression whereby inline neon is not enabled

Actually I'm a bit unsure about this patch (despite the fact I'm
submitting it).  It does do its job in that if you specify an armv7a cpu
then it will try to enable neon, but it is a bit mucky due to
uncertainties about exactly what capabilities each cpu actually has.

Really configure probably wants a --fpu= option, but my understanding of
how it is meant to work isn't up to that, so for the moment if the fpu
type is specified by the user then I expect it to turn up in
cextra_flags.

I'll also note that probe_arm_arch ends up setting subarch to armv7-a
when the other bits of the script expect armv7a (although gcc wants
armv7-a in -march).  Again I am confused by this but I'm not sure what
the right answer is let alone the correct fix.  Maybe whoever wrote this
bit of configure could revisit it?

Regards

John Cox
-------------- next part --------------
A non-text attachment was scrubbed...
Name: neon_inline.patch
Type: application/octet-stream
Size: 455 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180607/ea39f04b/attachment.obj>


More information about the ffmpeg-devel mailing list