[FFmpeg-devel] [PATCH 6/6] avformat/mxfdec: add support for recognizing timed text streams

Marton Balint cus at passwd.hu
Tue Jun 5 21:33:34 EEST 2018



On Tue, 5 Jun 2018, Tomas Härdin wrote:

> tor 2018-05-31 klockan 02:05 +0200 skrev Marton Balint:
>> > Signed-off-by: Marton Balint <cus at passwd.hu>
>> ---
>>  libavformat/mxfdec.c | 8 ++++++++
>>  1 file changed, 8 insertions(+)
>> 
>> +            type = avcodec_get_type(st->codecpar->codec_id);
>> +            if (type == AVMEDIA_TYPE_SUBTITLE)
>> +                st->codecpar->codec_type = type;
>
> This feels like something that belongs in more generic parts of lavf.
> Filling codecpar with defaults for some given codec_id that is.

I assumed some codecs can be audio and video at the same time, and this is 
why it's not automatic. wrapped_avframe (like it or not) is such a codec. 
In any case, I'd rather not change the way it works here...

Regards,
Marton


More information about the ffmpeg-devel mailing list