[FFmpeg-devel] [GSOC] [PATCH] On the fly generation of default DNN models and code style fixes

[Michael Niedermayer]

On Fri, Jul 27, 2018 at 08:06:15PM +0300, Sergey Lavrushkin wrote:
> Hello,
> 
> The first patch provides on the fly generation of default DNN models,
> that eliminates data duplication for model weights. Also, files with
> internal weights
> were replaced with automatically generated one for models I trained.
> Scripts for training and generating these files can be found here:
> https://github.com/HighVoltageRocknRoll/sr
> Later, I will add a description to this repo on how to use it and benchmark
> results for trained models.
> 
> The second patch fixes some code style issues for pointers in DNN module
> and sr filter. Are there any other code style fixes I should make for this
> code?


It seems the code with these patches produces some warnings:

In file included from libavfilter/dnn_backend_native.c:27:0:
libavfilter/dnn_srcnn.h:2113:21: warning: ‘srcnn_consts’ defined but not used [-Wunused-variable]
 static const float *srcnn_consts[] = {
                     ^
libavfilter/dnn_srcnn.h:2122:24: warning: ‘srcnn_consts_dims’ defined but not used [-Wunused-variable]
 static const long int *srcnn_consts_dims[] = {
                        ^
libavfilter/dnn_srcnn.h:2142:20: warning: ‘srcnn_activations’ defined but not used [-Wunused-variable]
 static const char *srcnn_activations[] = {
                    ^
In file included from libavfilter/dnn_backend_native.c:28:0:
libavfilter/dnn_espcn.h:5401:21: warning: ‘espcn_consts’ defined but not used [-Wunused-variable]
 static const float *espcn_consts[] = {
                     ^
libavfilter/dnn_espcn.h:5410:24: warning: ‘espcn_consts_dims’ defined but not used [-Wunused-variable]
 static const long int *espcn_consts_dims[] = {
                        ^
libavfilter/dnn_espcn.h:5432:20: warning: ‘espcn_activations’ defined but not used [-Wunused-variable]
 static const char *espcn_activations[] = {
                    ^


[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Why not whip the teacher when the pupil misbehaves? -- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180728/59e757e9/attachment.sig>