[FFmpeg-devel] [PATCH] libavfilter: temporarily remove DNN framework and vf_sr filter

[Thilo Borgmann]

Hi,

Am 26.07.18 um 21:26 schrieb Rostislav Pehlivanov:
> As discussed recently, the vf_sr filter and the DNN framework have an
> issue: unreproducable weights and questionable license, as well as
> overall unfitting coding style to the rest of the project.
> 
> The vf_sr filter in particular has weights embedded which weight the
> libavfilter binary by a bit and cannot currently be reproduced.
> There's an overall consensus that NN filters should accept external
> weights only, as the nnedi filter currently does.
> 
> So, temporarily remove both until the coding style issues have been
> fixed with the framework and the filter has been modified to accept
> external weights.
> 
> Also, there's a discussion by the Debian folks as to whether to treat
> pretrained NNs as non-free[0], hence its not just our project that's
> affected by the questionable license of distributing pretrained NN
> weights.

I personally don't have a good feeling with pre-trained NNs in the codebase, too. However, I do not care much about what solution we take, but Mina's GSoC project also depends on the NN code that comes with this and therefore I'd encourage everyone to make up their mind to find a suitable solution sometime soonish.

Maybe for the time-being, we might only accept such code reading in externally provided NNs and/or the ability to train using FFmpeg itself. (Or ask one of our kind users with compute power to generate some for us)


> Due to the weight of the patch (more than 1mb!) I've uploaded it to
> https://0x0.st/sVEH.patch if anyone wants to test it. The change stat
> is printed below.
> 
> [0]: https://lwn.net/Articles/760142/
> 
> Signed-off-by: Rostislav Pehlivanov <atomnuker at gmail.com>
> 
> Rostislav Pehlivanov (1):
>   libavfilter: temporarily remove DNN framework and vf_sr filter
> 
>  Changelog                        |     1 -
>  configure                        |     8 -
>  libavfilter/Makefile             |     3 -
>  libavfilter/allfilters.c         |     1 -
>  libavfilter/dnn_backend_native.c |   495 --
>  libavfilter/dnn_backend_native.h |    40 -
>  libavfilter/dnn_backend_tf.c     |   325 -
>  libavfilter/dnn_backend_tf.h     |    40 -
>  libavfilter/dnn_espcn.h          | 12637 -----------------------------
>  libavfilter/dnn_interface.c      |    60 -
>  libavfilter/dnn_interface.h      |    63 -
>  libavfilter/dnn_srcnn.h          |  4957 -----------
>  libavfilter/vf_sr.c              |   354 -
>  13 files changed, 18984 deletions(-)
>  delete mode 100644 libavfilter/dnn_backend_native.c
>  delete mode 100644 libavfilter/dnn_backend_native.h
>  delete mode 100644 libavfilter/dnn_backend_tf.c
>  delete mode 100644 libavfilter/dnn_backend_tf.h
>  delete mode 100644 libavfilter/dnn_espcn.h
>  delete mode 100644 libavfilter/dnn_interface.c
>  delete mode 100644 libavfilter/dnn_interface.h
>  delete mode 100644 libavfilter/dnn_srcnn.h
>  delete mode 100644 libavfilter/vf_sr.c
> 

-Thilo