[FFmpeg-devel] [PATCH]lavf/mov: Make auxiliary_offsets consistently size_t.

[Michael Niedermayer]

On Tue, Jul 24, 2018 at 10:36:06PM +0200, Carl Eugen Hoyos wrote:
> 2018-07-21 22:43 GMT+02:00, Michael Niedermayer <michael at niedermayer.cc>:
> > On Sat, Jul 21, 2018 at 03:52:19PM +0200, Carl Eugen Hoyos wrote:
> >> Hi!
> >>
> >> Attached patch fixes a warning on ppc32:
> >> libavformat/mov.c: In function ‘mov_read_saio’:
> >> libavformat/mov.c:6207:45: warning: assignment from incompatible
> >> pointer type [-Wincompatible-pointer-types]
> >>          encryption_index->auxiliary_offsets = auxiliary_offsets;
> >>                                              ^
> >>
> >> Please comment, Carl Eugen
> >
> > This array is used to store 64bit values if version > 0, size_t
> > may be smaller, is that intended ?
> 
> No, new patch attached.
> 
> Thank you, Carl Eugen

>  isom.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> f200dfc84a8bc6b4e61c71daa05f3fa567b42b6d  0001-lavf-isom-Make-auxiliary_offsets-consistently-uint64.patch
> From e10383b0e27686f4650ee75b2e719579cf181e0a Mon Sep 17 00:00:00 2001
> From: Carl Eugen Hoyos <ceffmpeg at gmail.com>
> Date: Tue, 24 Jul 2018 22:32:59 +0200
> Subject: [PATCH] lavf/isom: Make auxiliary_offsets consistently uint64_t.
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
> 
> Fixes a compilation warning if size_t != uint64_t:
> libavformat/mov.c: In function ‘mov_read_saio’:
> libavformat/mov.c:6207:45: warning: assignment from incompatible pointer type [-Wincompatible-pointer-types]
>          encryption_index->auxiliary_offsets = auxiliary_offsets;
>                                              ^
> ---
>  libavformat/isom.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

probably ok

thx
[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Whats the most studid thing your enemy could do ? Blow himself up
Whats the most studid thing you could do ? Give up your rights and
freedom because your enemy blew himself up.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180725/b76cd762/attachment.sig>