[FFmpeg-devel] [PATCH v4][GSOC] avfilter: added colorconstancy

Rostislav Pehlivanov atomnuker at gmail.com
Tue Jul 24 20:06:03 EEST 2018


On 24 July 2018 at 17:10, Paul B Mahol <onemda at gmail.com> wrote:

> On 7/24/18, Rostislav Pehlivanov <atomnuker at gmail.com> wrote:
> > On 23 July 2018 at 21:36, Thilo Borgmann <thilo.borgmann at mail.de> wrote:
> >
> >> Am 19.07.18 um 08:26 schrieb Thilo Borgmann:
> >> >
> >> >
> >> >> Am 16.07.2018 um 13:41 schrieb Mina <minas.gorgy at gmail.com>:
> >> >>
> >> >> Hi,
> >> >>
> >> >>   This patch introduces Grey-Edge algorithm as part of the Color
> >> Constancy Filter project in GSOC.
> >> >>
> >> >> V4 changes:
> >> >> - Fixed error in filter.texi that resulted in breaking "make
> >> doc/ffprobe-all.html"
> >> >
> >> > If there are no more comments coming in I`ll push this in a couple of
> >> days.
> >>
> >> Applied.
> >>
> >> -Thilo
> >> _______________________________________________
> >> ffmpeg-devel mailing list
> >> ffmpeg-devel at ffmpeg.org
> >> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >>
> >
> > What's the point of having an imperfect color conversion filter that
> could
> > screw up compared to a mathematically sound approach?
> > After realizing what this filter does I'm kinda against it and would
> rather
> > we not have an unmaintainable, unused color conversion filter and I think
> > if there's no reasoning behind it I'd like it reverted.
> > _______________________________________________
> > ffmpeg-devel mailing list
> > ffmpeg-devel at ffmpeg.org
> > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >
>
> This is not color conversion filter.
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>

Use whatever terminology you'd like, its still not something I'd consider
acceptable. I want to be able to reproduce the results and the NN weights
and I can't.


More information about the ffmpeg-devel mailing list