[FFmpeg-devel] avcodec/proresenc_aw improvements

[Michael Niedermayer]

On Sun, Jul 22, 2018 at 01:04:29PM +0200, Martin Vignali wrote:
> >
> > > 001 : use scantable in prores_data instead of a duplicate one.
> >
> > This could negativly affect the performance of the changed inner loop
> > have you checked that the changed function does not become slower ?
> >
> >
> >
> No, i will make some tests.
> 
> > > -    *buf++ = 6;
> > > +    *buf++ = pict->color_primaries;
> > > +    *buf++ = pict->color_trc;
> > > +    *buf++ = pict->colorspace;
> >
> > Has someone confirmed that all values our enum contains or will
> > contain can just be written with no check ?
> >
> >
> Mostly see prores with Rec709, Rec601. Need to take a look for Rec2020.
> Don't know if all value are authorized, doesn't use other colorspace, with
> prores.
> 

> Do you think it's better to only authorize few colorspace ?

depends on what happens if "others" are stored.
if the official decoders fail with a blank screen then its probably
not a good idea to use such a value. If OTOH they ignore values they
do not support then it may be ok. 

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No human being will ever know the Truth, for even if they happen to say it
by chance, they would not even known they had done so. -- Xenophanes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180723/5ec1a470/attachment.sig>