[FFmpeg-devel] [PATCH] libavcodec/escape130: fixes and improvements

[Michael Chaban]

2018-07-19 21:28 GMT+03:00 Carl Eugen Hoyos <ceffmpeg at gmail.com>:
> The first commit breaks fate, you have to (confirm the fix and)
> change the reference values in the same patch.

The first commit fixes the wrong decoding which was error in first
place for FFmpeg Escape130 implementation. The decoded frame examples
and RPL video file were presented in the first message. Sorry, It's my
first time in contributing to FFmpeg, so I don't understand what
exactly I have to do to make things right. How to confirm the fix and
change the reference values?

2018-07-19 21:28 GMT+03:00 Carl Eugen Hoyos <ceffmpeg at gmail.com>:
> Is there an alternative to the second patch? Like setting the
> range correctly?

Actually AVCOL_RANGE_JPEG can made the colorspace visually correct,
since T-REC-T.871 is primarily used by JPEG. But the original decoder
applies additional color patten to solid colour 2x2 pixel blocks (my
commit 3/3). If I use AV_PIX_FMT_YUV420P I cannot apply the same RGB
pattern. In this case I'll have to use Luma pattern instead, which is
little different. What is more inportant: original decoder algorythm
or YUV420P pixel format?

Thank you, Michael Chaban