[FFmpeg-devel] [PATCH 4/5] avformat/mov: add support for AV1 streams

[Francois Cartegnie]

Hi,

Sorry, can't reply to thread.

> +    if (version != 0) {
> +        av_log(c->fc, AV_LOG_WARNING, "Unknown AV1 Codec Configuration Box version %d\n", version);
> +        return 0;
> +    }
> +    avio_skip(pb, 3); /* flags */
> +
> +    avio_skip(pb, 1); /* reserved, initial_presentation_delay_present, initial_presentation_delay_minus_one */
> +
> +    ret = ff_get_extradata(c->fc, st->codecpar, pb, atom.size - 5);

Seems to me that using OBU only as internal extradata, unlike h264 or
hevc, will only cause issues.

There's no version as a guarantee on which OBU should be found, and it
implies parsing OBU just like with AnnexB.
Parsing might also not be possible without accessing samples data when
there's potentially zero OBU in DCR.

I've raised the issue on the spec, as the DCR itself does not seems to
contain enough extracted information, like profile for routing to a
proper decoder.

-- 
Francois Cartegnie
VideoLAN - VLC Developer