[FFmpeg-devel] [PATCH 1/2] libavcodec/cfhd: Fix signed overflow in shift

Michael Niedermayer michael at niedermayer.cc
Sat Jul 14 02:14:24 EEST 2018


Fixes: 8695/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_CFHD_fuzzer-4906172426485760

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
---
 libavcodec/cfhd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavcodec/cfhd.c b/libavcodec/cfhd.c
index 051d210355..ef5ebe42c5 100644
--- a/libavcodec/cfhd.c
+++ b/libavcodec/cfhd.c
@@ -541,7 +541,7 @@ static int cfhd_decode(AVCodecContext *avctx, void *data, int *got_frame,
             s->peak.level   = 0;
         } else if (tag == -76) {
             s->peak.offset &= 0xffff;
-            s->peak.offset |= (data & 0xffff)<<16;
+            s->peak.offset |= (data & 0xffffU)<<16;
             s->peak.base    = (int16_t *) gb.buffer;
             s->peak.level   = 0;
         } else if (tag == -74 && s->peak.offset) {
-- 
2.18.0



More information about the ffmpeg-devel mailing list