[FFmpeg-devel] [PATCH] Use channel count if channel layout is undefined

[Nicolas George]

Marcin Gorzel (2018-07-09):
> Subject: Re: [FFmpeg-devel] [PATCH] Use channel count if channel layout is undefined

Please remember to mention "lswr" or "libswresample" in the first line
of the commit message.

> Rematrixing supports up to 64 channels but there is only a limited
> number of channel layouts defined. Currently, in/out channel count is
> obtained from the channel layout so if the channel layout is undefined
> (e.g. for 9, 10, 11 channels etc.) the in/out channel count will be 0
> and the rematrixing will fail. This change adds a check if the channel
> layout is non-zero, and if not, prefers to use the in|out_ch_count
> instead. This seems to be related to ticket #6790.

I do not understand how it can work: the actual layouts are necessary to
build the matrix, otherwise it is not possible to know which channel
needs to be mixed into which. Can you explain how this patch was tested?

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180709/d0e89531/attachment.sig>