[FFmpeg-devel] [FFmpeg-cvslog] Adds ESPCN super resolution filter merged with SRCNN filter.

[Jean-Baptiste Kempf]

On Mon, 2 Jul 2018, at 20:52, Pedro Arthur wrote:
> >> > Where do they come from, how can we recreate them?
> >> Paper link [1], and web page with reference matlab code [2].
> >
> > This code is not open source, and is not compatible with LGPLv2.1:
> >
> > "If you use/adapt our code in your work (either as a stand-alone tool or as a component of any algorithm),
> > you need to appropriately cite our ECCV 2014 paper or arXiv paper."
> >
> > Reimplementation of the code in a different language does not remove IP.
> The paper is properly cited in libavfilter/vf_sr.c.
> 
> I not specialist in  IP rights but  there is nothing novel in the code
> (TBH there is no code at all, look at srcnn.m) it is just plain
> convolution, basic math machinery, we are just applying a bunch of
> filter convolution to an image.

Well, either it is based on a paper and the matlab code, or it is not.
If it is, it's a big issue, since this is not open source compatible.

If it is just convolution, then why is it based on this paper?
What is the source of those numbers?

> If you're referring to using his trained data, Ok, we could train our
> own weights if it is really an issue.

Sorry, but you need to be able to give the source of your code. Aka the original source that can create the code.

> >> >> The espcn was trained by Sergey, if needed we can provide the TF
> >> >> model/ training data.
> >> >
> >> > Same remark.
> >> Paper [3], for this model Sergey used his own trained weights.
> >> If needed, you can ask him directly for the training data set and
> >> TensorFlow model for both methods.
> >
> > Where is the data set then? How was it trained? How can we reproduce them?
> CC'ing Sergey, so he can provide any data you want.

Same remark as above.



-- 
Jean-Baptiste Kempf -  President
+33 672 704 734