[FFmpeg-devel] [PATCH 1/3] avcodec/mpeg4videodec: Check mb_num also against 0
Michael Niedermayer
michael at niedermayer.cc
Sun Jan 28 03:29:00 EET 2018
The spec implies that 0 is invalid in addition to the existing checks
Found-by: <kierank>
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
---
libavcodec/mpeg4videodec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/mpeg4videodec.c b/libavcodec/mpeg4videodec.c
index 12755b5e8a..ba332de531 100644
--- a/libavcodec/mpeg4videodec.c
+++ b/libavcodec/mpeg4videodec.c
@@ -465,7 +465,7 @@ int ff_mpeg4_decode_video_packet_header(Mpeg4DecContext *ctx)
}
mb_num = get_bits(&s->gb, mb_num_bits);
- if (mb_num >= s->mb_num) {
+ if (mb_num >= s->mb_num || !mb_num) {
av_log(s->avctx, AV_LOG_ERROR,
"illegal mb_num in video packet (%d %d) \n", mb_num, s->mb_num);
return -1;
--
2.16.1
More information about the ffmpeg-devel
mailing list