[FFmpeg-devel] [PATCH 3/4] lavfi/procamp_vaapi: fix the green output issue.
mypopydev at gmail.com
Wed Jan 24 02:31:29 EET 2018
On 2018/1/24 7:52, Carl Eugen Hoyos wrote:
> 2018-01-23 5:33 GMT+01:00 Jun Zhao <mypopydev at gmail.com>:
>> - procamp_params[i].type = VAProcFilterColorBalance;
>> + procamp_params[i].type = VAProcFilterColorBalance;
> Please split this patch, so that functional change and re-indentation
> of a large block do not happen in the same patch: This not only
> makes reviewing easier, it also simplifies understanding the
> patch at a later time.
> While there, I suggest you post one patch to change the typos
> in all files without non-typo changes.
Thanks the suggestion and comments, carl, will submit V2 follow.
> Carl Eugen
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
More information about the ffmpeg-devel