[FFmpeg-devel] [PATCH] mpeg4video: Add support for MPEG-4 Simple Studio Profile.

[Kieran Kunhya]

On Sun, Jan 21, 2018 at 1:08 PM, Carl Eugen Hoyos <ceffmpeg at gmail.com>
wrote:

> 2018-01-21 14:03 GMT+01:00 Kieran Kunhya <kieran618 at googlemail.com>:
> > On Sun, Jan 21, 2018 at 12:53 PM, Carl Eugen Hoyos <ceffmpeg at gmail.com>
> > wrote:
> >
> >> 2018-01-21 13:37 GMT+01:00 Kieran Kunhya <kieran618 at googlemail.com>:
> >> > On Mon, Jan 1, 2018 at 7:01 PM, Michael Niedermayer wrote:
> >> >
> >> >> Hi
> >> >
> >> > Patch updated.
> >>
> >> If you choose to ignore more than half of the comments made,
> >> please at least answer the review to explain why you
> >> believe the comments were not helpful.
> >>
> >> > Some of the review comments I decided not to implement
> >> > in order to keep closer to the spec.
> >>
> >> We have agreed in the past (on trac) that specifications
> >> are not necessarily written with the intention to allow
> >> writing good implementations, so I am not convinced
> >> this is a sufficient argumentation.
> >>
> > Ok, well I only did not implement a couple.
>
> > The startcode one conflates studio start codes with mpeg4 start codes.
>
> (Looking up "conflate" did not help me here...)
>

They are not the same start codes and the spec specifically says search for
new start codes (i.e there can be padding data of some sort).

>
> > The show_bits one I'd rather keep it as per the spec.
>
> You don't agree that the code gets more readable if
> you can reduce the number of commands by reordering?
>

I personally would like to see the code and spec be understandable together.

> The n&1 comment the compiler should be able to deal with


I will be committing this patch soon.

Kieran