[FFmpeg-devel] [PATCH] avfilter/vidstab: set bytesPerPixel only for packed formats.

Michael Niedermayer michael at niedermayer.cc
Wed Jan 17 04:27:27 EET 2018

On Tue, Jan 16, 2018 at 05:52:52PM +0530, Gyan Doshi wrote:
> On 1/16/2018 5:19 PM, Michael Niedermayer wrote:
> >On Thu, Jan 11, 2018 at 12:15:00PM +0530, Gyan Doshi wrote:
> >>
> >>On 1/11/2018 6:16 AM, Michael Niedermayer wrote:
> >>>>>>
> >>>>>>Georg, do you want to maintain vf_vidstabtransform.c ?
> >>>>>>
> >>>>>>If not, who wants to maintain vf_vidstabtransform.c ?
> >>>>>>
> >>>>>>If noone then iam not sure who will test or apply this, i think many
> >>>>>>dont have the dependancy installed ...
> >>>>>
> >>>>>I assume the author hasn't gotten back yet. Can anyone else test and apply
> >>>>>this?
> >>>>
> >>>>Anyone?
> >>>
> >>>If noone else cares about maintaining this ...
> >>>then there is one radical but simple solution ...
> >>>post a patch that adds you to MAINTAINERs for the file.
> >>>
> >>>Anyone could object yes, but then that person should at least review and apply
> >>>the vf_vidstabtransform.c patch
> >>
> >>I have no interest or business maintaining the library wrappers.
> >>
> >>In the commit history for these files, I see Paul Mahol, Clément Bœsch and
> >>you as committers among those active. Timothy Gu has signed off as well, but
> >>I don't know if he's active.
> >>
> >>So, someone among the above could take a look?
> >
> >Please correct me if i misunderstand but IIUC you basically say
> >you wont review patches for vf_vidstabtransform (that is what maintaining is)
> >but you want other people to review your patches for vf_vidstabtransform
> I won't review patches for vidstab because I can't. There is an open ticket
> which has a simple fix which I noticed, applied & tested. But I'm not
> well-versed in the internals of vidstab to be a competent maintainer for all
> other patches, as they may come up.
> I believe you suggested to propose myself for maintainership *as a ruse* to
> get someone to review my patch and not in earnest. If you were, it would be
> insincere for me to go through with it.

it was not intended "as a ruse" to get someone to review the patch. Maybe as
a "ruse" to get someone to maintain the code but really i was just trying to
write it a bit funny in hope that this would more likely get a positive reaction
from someone ...

the code really needs someone to maintain it.

> I can vouch that the patch works at my end, and if that's not enough, it

ill apply it then after annother look, but i too do not have very deep
knowledge of vf_vidstabtransform. 

> will still need to be tested/reviewed by someone else.

> I can propose myself as a maintainer for docs if you are amenable.

Which docs do you want to maintain ?
I think for anything thats unmaintained, a maintainer would be welcome



Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

"I am not trying to be anyone's saviour, I'm trying to think about the
 future and not be sad" - Elon Musk

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180117/8fabffa9/attachment.sig>

More information about the ffmpeg-devel mailing list