[FFmpeg-devel] [PATCH 4/5] lavfi: add ProcAmp(color balance) vaapi video filter.

[Mark Thompson]

On 14/01/18 22:59, Carl Eugen Hoyos wrote:
>> On 08/01/18 08:35, Jun Zhao wrote:
> 
>>> +    VAStatus vas;
> 
>>> +        av_log(avctx, AV_LOG_ERROR, "Failed to Query procamp "
>>> +               "query caps: %d (%s).\n", vas, vaErrorStr(vas));
> 
> Is "%d" what it's supposed to be? Why is VAStatus needed then?

Yes: <https://github.com/01org/libva/blob/master/va/va.h#L170>.

I guess VAStatus is there to suggest to the user to keep different namespaces of error codes apart?  Since the types are the same the compiler unfortunately doesn't actually help to check it, though.

- Mark