[FFmpeg-devel] [PATCH] avfilter: add foobar filter.

[Moritz Barsnick]

On Thu, Jan 11, 2018 at 21:57:11 +0100, Dmytro Humeniuk wrote:

You forget to comment on or react to all the reviews you got. How about
a result normalized to 0.0 .. 1.0, for example? (dB for SoundCloud
could be a special case/option.) How about getting rid of the switch/case by
supporting just few input sample formats? How about its comparison to
other filter chains? How about metadata?

> avfilter: add foobar filter.
                ^ wrong name

> +static const AVOption dumpwave_options[] = {
> +    { "s", "set width and height", OFFSET(w), AV_OPT_TYPE_IMAGE_SIZE, {.str = "1800x140"}, 0, 0, FLAGS },
> +    { "size", "set width and height", OFFSET(w), AV_OPT_TYPE_IMAGE_SIZE, {.str = "1800x140"}, 0, 0, FLAGS },
> +    { "n", "set number of samples per value per channel",  OFFSET(nb_samples), AV_OPT_TYPE_INT64,  {.i64 = 128}, 1, INT64_MAX, FLAGS },
> +    { "nb_samples", "set number of samples per value per channel",  OFFSET(nb_samples), AV_OPT_TYPE_INT64,  {.i64 = 128}, 1, INT64_MAX, FLAGS },
> +    { "f", "set json dump file", OFFSET(json_filename), AV_OPT_TYPE_STRING, { .str = NULL }, 0, 0, FLAGS },
> +    { "json", "set json dump file", OFFSET(json_filename), AV_OPT_TYPE_STRING, { .str = NULL }, 0, 0, FLAGS },
> +    { NULL }
> +};


Much nicer and more consistent than before, thanks.

Moritz