[FFmpeg-devel] [PATCH 01/11] libavdevice/decklink: Add support for EIA-708 output over SDI

Devin Heitmueller dheitmueller at ltnglobal.com
Wed Jan 10 16:11:35 EET 2018

Hello Moritz,

> On Wed, Jan 10, 2018 at 14:29:43 +0100, Moritz Barsnick wrote:
>>> +        for (size_t i = 0; i < cc_count; i++) {
>> Declare i outside the clause.
>>> +    for (int i = 0; i < vanc_lines.num_lines; i++) {
>> Same here.
> Sorry, this rule may not apply to C++ files, as it's part of all C++
> standards and all compilers should support it. Others may know more.

For loop declaration has been part of the C standard since C99.  I’m not against changing it if required, but I’ve already revised the patch series multiple times and would prefer that demands for such stylistic cleanup either be pointed out in the first review or I can submit such changes as subsequent patches.

If the patch needs to be revised for some good technical reason, I will incorporate these changes.


More information about the ffmpeg-devel mailing list