[FFmpeg-devel] [PATCH] add dumpwave filter

Kyle Swanson k at ylo.ph
Wed Jan 10 09:43:45 EET 2018


Hi,

On Tue, Jan 9, 2018 at 3:49 PM,  <dmitry.gumenyuk at gmail.com> wrote:
> From: Dmytro Humeniuk <dmitry.gumenyuk at gmail.com>
>
> Signed-off-by: Dmytro Humeniuk <dmitry.gumenyuk at gmail.com>
> ---
>  Changelog                      |   1 +
>  doc/filters.texi               |  23 ++++
>  libavfilter/Makefile           |   1 +
>  libavfilter/af_dumpwave.c      | 285
+++++++++++++++++++++++++++++++++++++++++
>  libavfilter/allfilters.c       |   1 +
>  libavfilter/version.h          |   4 +-
>  tests/fate/filter-audio.mak    |   5 +
>  tests/ref/fate/filter-dumpwave |   1 +
>  8 files changed, 319 insertions(+), 2 deletions(-)
>  create mode 100644 libavfilter/af_dumpwave.c
>  create mode 100644 tests/ref/fate/filter-dumpwave

I could see this possibly being a useful filter, but I'm confused about
where the JSON schema came from. The two JS libraries that do this type of
thing (waveform.js, and wavesurer.js) both just load waveform data as an
array of floats. If we're going to add something like this to libavfilter
it should be as generic and extensible as possible. I'm not wild about the
string stuff, and the big sample format switch isn't necessary. I could do
a code review, but it might just be faster if I rewrite it and send another
patch. Is that OK with you?

Thanks,
Kyle


More information about the ffmpeg-devel mailing list