[FFmpeg-devel] [PATCH 3/4] avformat/libopenmpt: Update file extensions list for libopenmpt 0.3

[Jörn Heusipp]

On 01/06/2018 04:06 PM, Carl Eugen Hoyos wrote:
> 2018-01-06 11:07 GMT+01:00 Jörn Heusipp <osmanx at problemloesungsmaschine.de>:
>> Signed-off-by: Jörn Heusipp <osmanx at problemloesungsmaschine.de>
>> ---
>>   libavformat/libopenmpt.c | 6 +++++-
>>   1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/libavformat/libopenmpt.c b/libavformat/libopenmpt.c
>> index 30c3d6e..5efbdc4 100644
>> --- a/libavformat/libopenmpt.c
>> +++ b/libavformat/libopenmpt.c
>> @@ -234,5 +234,9 @@ AVInputFormat ff_libopenmpt_demuxer = {
>>       .read_close     = read_close_openmpt,
>>       .read_seek      = read_seek_openmpt,
>>       .priv_class     = &class_openmpt,
>> -    .extensions     = "669,amf,ams,dbm,digi,dmf,dsm,far,gdm,imf,it,j2b,m15,mdl,med,mmcmp,mms,mo3,mod,mptm,mt2,mtm,nst,okt,plm,ppm,psm,pt36,ptm,s3m,sfx,sfx2,stk,stm,ult,umx,wow,xm,xpk",
>> +#if OPENMPT_API_VERSION_AT_LEAST(0,3,0)
>> +    .extensions     = "669,amf,ams,dbm,digi,dmf,dsm,dtm,far,gdm,ice,imf,it,j2b,m15,mdl,med,mmcmp,mms,mo3,mod,mptm,mt2,mtm,nst,okt,plm,ppm,psm,pt36,ptm,s3m,sfx,sfx2,st26,stk,stm,stp,ult,umx,wow,xm,xpk",
>> +#else
>> +    .extensions     = "669,amf,ams,dbm,digi,dmf,dsm,far,gdm,ice,imf,it,j2b,m15,mdl,med,mmcmp,mms,mo3,mod,mptm,mt2,mtm,nst,okt,plm,ppm,psm,pt36,ptm,s3m,sfx,sfx2,st26,stk,stm,ult,umx,wow,xm,xpk",
>> +#endif
> 
> I believe this change can be made without the version check.

Why would that be better? I cannot see much use in listing file 
extensions that are not supported by the libopenmpt version ffmpeg 
builds against.
If you prefer to have that changed, I'll do so. I would merely like to 
understand the reasons why.

Regards,
Jörn