[FFmpeg-devel] [PATCH] doc/filters: add links to ffmpeg-utils and ffmpeg documentation

Tobias Rapp t.rapp at noa-archive.com
Thu Feb 22 09:59:33 EET 2018


On 21.02.2018 23:27, Lou Logan wrote:
> On Tue, Feb 20, 2018, at 2:01 AM, Tobias Rapp wrote:
>> Signed-off-by: Tobias Rapp <t.rapp at noa-archive.com>
>> ---
>>   doc/filters.texi | 48 ++++++++++++++++++++++++++----------------------
>>   1 file changed, 26 insertions(+), 22 deletions(-)
> [...]
>> @@ -9322,8 +9323,9 @@ A '|'-separated list of parameters to pass to the
>> frei0r effect.
>>   A frei0r effect parameter can be a boolean (its value is either
>>   "y" or "n"), a double, a color (specified as
>>   @var{R}/@var{G}/@var{B}, where @var{R}, @var{G}, and @var{B} are
>> floating point
>> -numbers between 0.0 and 1.0, inclusive) or by a color description
>> specified in the "Color"
>> -section in the ffmpeg-utils manual), a position (specified as @var{X}/
>> @var{Y}, where
>> +numbers between 0.0 and 1.0, inclusive) or by a color description
>> specified in the
>> + at ref{color syntax,,"Color" section in the ffmpeg-utils manual,ffmpeg-
>> utils}),
> 
> You can remove that errant ")" if you feel like it (I know you didn't introduce that).
> 
> Otherwise, LGTM.

Have removed the superfluous ")" and slightly adjusted the sentence.

> I have never really liked the resulting link structure as shown in the HTML output, but I don't hate it enough to actually do anything about it.
> 

Pushed the patch, thanks for review.

Regards,
Tobias



More information about the ffmpeg-devel mailing list