[FFmpeg-devel] [PATCH 2/2] fate: add tests for pan audio filter

Nicolas George george at nsup.org
Thu Feb 15 10:39:59 EET 2018


Tobias Rapp (2018-02-15):
> Signed-off-by: Tobias Rapp <t.rapp at noa-archive.com>
> ---
>  tests/fate/filter-audio.mak       | 30 ++++++++++++++++++++++++++++++
>  tests/ref/fate/filter-pan-mono1   | 26 ++++++++++++++++++++++++++
>  tests/ref/fate/filter-pan-mono2   | 26 ++++++++++++++++++++++++++
>  tests/ref/fate/filter-pan-stereo1 | 26 ++++++++++++++++++++++++++
>  tests/ref/fate/filter-pan-stereo2 | 26 ++++++++++++++++++++++++++
>  tests/ref/fate/filter-pan-stereo3 | 26 ++++++++++++++++++++++++++
>  tests/ref/fate/filter-pan-stereo4 | 26 ++++++++++++++++++++++++++
>  7 files changed, 186 insertions(+)
>  create mode 100644 tests/ref/fate/filter-pan-mono1
>  create mode 100644 tests/ref/fate/filter-pan-mono2
>  create mode 100644 tests/ref/fate/filter-pan-stereo1
>  create mode 100644 tests/ref/fate/filter-pan-stereo2
>  create mode 100644 tests/ref/fate/filter-pan-stereo3
>  create mode 100644 tests/ref/fate/filter-pan-stereo4

I think the change in lswr is sane, but I do not know enough of that
code to be definite. Thanks for tracking down that ticket.

As for this patch, thanks for implementing it. It looks reasonable. But
I am not entirely sure lsws is bit-exact in this kind of situation.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180215/acd5d336/attachment.sig>


More information about the ffmpeg-devel mailing list