[FFmpeg-devel] [PATCH 2/3] Add muxer/demuxer for raw codec2 and .c2 files

[Tomas Härdin]

tis 2018-02-13 klockan 11:48 +0100 skrev Tomas Härdin:
> fre 2018-02-09 klockan 11:29 +0100 skrev Carl Eugen Hoyos:
> > 2018-01-15 22:36 GMT+01:00 Tomas Härdin <tjoppen at acc.umu.se>:
> > 
> > > > +    if (p->buf[4] >  EXPECTED_CODEC2_MINOR_VERSION) score -=
> > > > AVPROBE_SCORE_MAX/5;
> > > > +    if (p->buf[5] >  AVPRIV_CODEC2_MODE_MAX)        score -=
> > > > AVPROBE_SCORE_MAX/5;
> > > > +    if (p->buf[6] != 0)                             score -=
> > > > AVPROBE_SCORE_MAX/5;
> > > > +    return score;
> > > > 
> > > > Imo, this is too complicated:
> > > > If the first 32bit are correct, return MAX/2, for 24bit, return
> > > > less
> > 
> > This should have been AVPROBE_SCORE_EXTENSION + 1,
> > sorry about my mistake.
> 
> Done.
> 
> > Please threaten to push this and push after a few days.
> 
> Alright, rebased. I'll push on Sunday if there's no objections
> 
> /Tomas

Aaaand a set that actually passes FATE this time :)

/Tomas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-libcodec2-en-decoder.patch
Type: text/x-patch
Size: 22361 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180214/26dccd77/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Add-muxer-demuxer-for-raw-codec2-and-.c2-files.patch
Type: text/x-patch
Size: 14299 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180214/26dccd77/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Don-t-complain-about-codec2-s-700-bit-s-modes-in-ffm.patch
Type: text/x-patch
Size: 1167 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180214/26dccd77/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-Add-myself-as-codec2-maintainer.patch
Type: text/x-patch
Size: 1262 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180214/26dccd77/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180214/26dccd77/attachment.sig>