[FFmpeg-devel] [PATCH 2/4] af_silencedetect : fix accuracy of silence_start

[Michael Niedermayer]

On Fri, Feb 02, 2018 at 11:01:20AM +0000, Gaullier Nicolas wrote:
> (attachement + email object fixed : sorry about that x2)
> Attached patch fixes accuracy of silence_start.
> The benefit is mostly noticeable when the silence starts at the very beginning (ie. silence_start=0 exactly).
> Nicolas Gaullier

>  af_silencedetect.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 0847308d6116f153553a9dab288eecaf8804cfe6  0002-avfilter-af_silencedetect-fix-silence_start-accuracy.patch
> From a8780b9c7132b80cd0f0f3cb99fc34bf38874f34 Mon Sep 17 00:00:00 2001
> From: nicolas gaullier <nicolas.gaullier at arkena.com>
> Date: Fri, 2 Feb 2018 11:14:47 +0100
> Subject: [PATCH 2/4] avfilter/af_silencedetect : fix silence_start accuracy

this breaks fate

make -j12 fate-filter-metadata-silencedetect
TEST    filter-metadata-silencedetect
--- ./tests/ref/fate/filter-metadata-silencedetect	2018-02-03 00:37:40.522808340 +0100
+++ tests/data/fate/filter-metadata-silencedetect	2018-02-03 02:57:28.310985048 +0100
@@ -4,9 +4,9 @@
 pkt_pts=960
 pkt_pts=1280
 pkt_pts=1600
-pkt_pts=1920|tag:lavfi.silence_start=0.02
+pkt_pts=1920|tag:lavfi.silence_start=0.0351875
 pkt_pts=2240
-pkt_pts=2560|tag:lavfi.silence_end=0.16|tag:lavfi.silence_duration=0.14
+pkt_pts=2560|tag:lavfi.silence_end=0.16|tag:lavfi.silence_duration=0.124813
 pkt_pts=2880
 pkt_pts=3200
 pkt_pts=3520
....

If the changes are intended the reference must be updated by the patch causing
the changes

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The misfortune of the wise is better than the prosperity of the fool.
-- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180203/d9b63bf4/attachment.sig>