[FFmpeg-devel] Remove carriage return ('\r') in Windows CC_IDENT

[Michael Niedermayer]

On Wed, Jan 31, 2018 at 02:35:29PM -0800, Xiaohan Wang (王消寒) wrote:
> 

>  configure |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> f8dfee52e94f632ac5803332e2fe050c9a880254  0001-Remove-carriage-return-r-in-Windows-CC_IDENT.patch
> From 07e33b2aa09b8b224ac35a5b56b29490a6486bdf Mon Sep 17 00:00:00 2001
> From: Xiaohan Wang <xhwang at chromium.org>
> Date: Wed, 31 Jan 2018 14:20:02 -0800
> Subject: [PATCH] Remove carriage return ('\r') in Windows CC_IDENT
> 
> Currently the Windows CC_IDENT is ended with '\r\n'. "head -n1" will not
> remove the '\r' and this is causing building error in Chromium.
> 
> This CL adds "tr -d '\r'" to remove '\r' in the CC_IDENT string. Since in
> most cases '\r' only appears at the end of a string/line, this should
> work in most cases.
> 
> See example:
> 
> printf "hello\r\nworld\r\n" | head -n1 | hd
> 00000000  68 65 6c 6c 6f 0d 0a                              |hello..|
> 
> printf "hello\r\nworld\r\n" | head -n1 | tr -d '\r' | hd
> 00000000  68 65 6c 6c 6f 0a                                 |hello.|
> 
> Also note a similar previous change at:
> https://lists.ffmpeg.org/pipermail/ffmpeg-cvslog/2013-October/069950.html
> ---
>  configure | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

will apply

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Old school: Use the lowest level language in which you can solve the problem
            conveniently.
New school: Use the highest level language in which the latest supercomputer
            can solve the problem without the user falling asleep waiting.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180201/b64c5d29/attachment.sig>