[FFmpeg-devel] [PATCH 11/16] avcodec/adpcm: use assert for codec id instead or error return

Michael Niedermayer michael at niedermayer.cc
Mon Dec 31 20:22:41 EET 2018


A unsupported codec_id is a internal error and should not happen

Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
---
 libavcodec/adpcm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavcodec/adpcm.c b/libavcodec/adpcm.c
index cd3bbd33c2..aa9c7c5c4f 100644
--- a/libavcodec/adpcm.c
+++ b/libavcodec/adpcm.c
@@ -1679,7 +1679,7 @@ static int adpcm_decode_frame(AVCodecContext *avctx, void *data,
         break;
 
     default:
-        return -1;
+        av_assert0(0); // unsupported codec_id should not happen
     }
 
     if (avpkt->size && bytestream2_tell(&gb) == 0) {
-- 
2.20.1



More information about the ffmpeg-devel mailing list