[FFmpeg-devel] [PATCH 1/2] lavfi/vaapi: Improve support for colour properties

[Michael Niedermayer]

On Sun, Dec 30, 2018 at 06:45:17PM +0000, Mark Thompson wrote:
> Attempts to pick the set of supported colour properties best matching the
> input.  Output is then set with the same values, except for the colour
> matrix which may change when converting between RGB and YUV.
> ---
>  libavfilter/vaapi_vpp.c            | 265 ++++++++++++++++++++++++++++-
>  libavfilter/vaapi_vpp.h            |   5 +-
>  libavfilter/vf_deinterlace_vaapi.c |  16 +-
>  libavfilter/vf_misc_vaapi.c        |  13 +-
>  libavfilter/vf_procamp_vaapi.c     |  13 +-
>  libavfilter/vf_scale_vaapi.c       |  12 +-
>  6 files changed, 292 insertions(+), 32 deletions(-)

breaks build:

CC	libavfilter/vaapi_vpp.o
libavfilter/vaapi_vpp.c: In function ‘vaapi_vpp_fill_chroma_sample_location’:
libavfilter/vaapi_vpp.c:348:37: error: ‘VA_CHROMA_SITING_UNKNOWN’ undeclared (first use in this function)
         { AVCHROMA_LOC_UNSPECIFIED, VA_CHROMA_SITING_UNKNOWN },
                                     ^
libavfilter/vaapi_vpp.c:348:37: note: each undeclared identifier is reported only once for each function it appears in
libavfilter/vaapi_vpp.c:349:30: error: ‘VA_CHROMA_SITING_VERTICAL_CENTER’ undeclared (first use in this function)
         { AVCHROMA_LOC_LEFT,        VA_CHROMA_SITING_VERTICAL_CENTER |
                              ^
libavfilter/vaapi_vpp.c:350:37: error: ‘VA_CHROMA_SITING_HORIZONTAL_LEFT’ undeclared (first use in this function)
                                     VA_CHROMA_SITING_HORIZONTAL_LEFT },
                                     ^
libavfilter/vaapi_vpp.c:352:37: error: ‘VA_CHROMA_SITING_HORIZONTAL_CENTER’ undeclared (first use in this function)
                                     VA_CHROMA_SITING_HORIZONTAL_CENTER },
                                     ^
libavfilter/vaapi_vpp.c:353:33: error: ‘VA_CHROMA_SITING_VERTICAL_TOP’ undeclared (first use in this function)
         { AVCHROMA_LOC_TOPLEFT,     VA_CHROMA_SITING_VERTICAL_TOP |
                                 ^
libavfilter/vaapi_vpp.c:357:36: error: ‘VA_CHROMA_SITING_VERTICAL_BOTTOM’ undeclared (first use in this function)
         { AVCHROMA_LOC_BOTTOMLEFT,  VA_CHROMA_SITING_VERTICAL_BOTTOM |
                                    ^
libavfilter/vaapi_vpp.c:370:38: warning: assignment makes integer from pointer without a cast [enabled by default]
     props->va_chroma_sample_location = VA_CHROMA_SITING_UNKNOWN;
                                      ^
libavfilter/vaapi_vpp.c: In function ‘vaapi_vpp_fill_colour_range’:
libavfilter/vaapi_vpp.c:377:33: error: ‘VA_SOURCE_RANGE_REDUCED’ undeclared (first use in this function)
         props->va_color_range = VA_SOURCE_RANGE_REDUCED;
                                 ^
libavfilter/vaapi_vpp.c:377:31: warning: assignment makes integer from pointer without a cast [enabled by default]
         props->va_color_range = VA_SOURCE_RANGE_REDUCED;
                               ^
libavfilter/vaapi_vpp.c:380:33: error: ‘VA_SOURCE_RANGE_FULL’ undeclared (first use in this function)
         props->va_color_range = VA_SOURCE_RANGE_FULL;
                                 ^
libavfilter/vaapi_vpp.c:380:31: warning: assignment makes integer from pointer without a cast [enabled by default]
         props->va_color_range = VA_SOURCE_RANGE_FULL;
                               ^
libavfilter/vaapi_vpp.c:384:33: error: ‘VA_SOURCE_RANGE_UNKNOWN’ undeclared (first use in this function)
         props->va_color_range = VA_SOURCE_RANGE_UNKNOWN;
                                 ^
libavfilter/vaapi_vpp.c:384:31: warning: assignment makes integer from pointer without a cast [enabled by default]
         props->va_color_range = VA_SOURCE_RANGE_UNKNOWN;
                               ^
make: *** [libavfilter/vaapi_vpp.o] Error 1
make: Target `all' not remade because of errors.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

"Nothing to hide" only works if the folks in power share the values of
you and everyone you know entirely and always will -- Tom Scott

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20181230/d61290c6/attachment.sig>