[FFmpeg-devel] [PATCH 2/6] avcodec/v4l2_m2m: fix cant typo

Michael Niedermayer michael at niedermayer.cc
Sun Dec 30 02:24:00 EET 2018


On Fri, Dec 28, 2018 at 11:35:52PM +0100, Moritz Barsnick wrote:
> On Fri, Dec 28, 2018 at 22:22:53 +0100, Michael Niedermayer wrote:
> > - * Reinitializes the V4L2m2mContext when the driver cant continue processing
> > + * Reinitializes the V4L2m2mContext when the driver cannot continue processing
> >   * with the  any of the current V4L2Contexts (ie, changes in output and capture).
> 
> The line below is also wrong. "with the any of" does not make any
> sense, and "ie," is very ugly.
> 
> Suggestion:
> 
>   Reinitializes the V4L2m2mContext when the driver cannot continue processing
>   with any of the current V4L2Contexts (i.e. changes in output and capture).
> 
> Even with "i.e.", the text in the parantheses doesn't make sense to me.
> My guess is "ie" meant to be "e.g.".
> 
> So:
> 
>   Reinitializes the V4L2m2mContext when the driver cannot continue processing
>   with any of the current V4L2Contexts (e.g. changes in output and capture).

I agree but this seems unrelated to the typo fix and its your change
its better if you commit this instead of it being added into the same
commit as the typo fix. 
also feel free to push trivial changes like mine if you want to work on
top of them so they dont hold you up

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many things microsoft did are stupid, but not doing something just because
microsoft did it is even more stupid. If everything ms did were stupid they
would be bankrupt already.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20181230/4e2c9d6b/attachment.sig>


More information about the ffmpeg-devel mailing list