[FFmpeg-devel] [PATCH 2/3] avcodec/lagarith: Optimize case with singleton probability distribution

[Derek Buitenhuis]

On 24/12/2018 00:14, Michael Niedermayer wrote:
> Fixes: Timeout
> Fixes: 10554/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_LAGARITH_fuzzer-5739938067251200
> 
> Found-by: continuous fuzzing processhttps://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> Signed-off-by: Michael Niedermayer<michael at niedermayer.cc>
> ---
>   libavcodec/lagarith.c    | 36 ++++++++++++++++++++++++++++++++++++
>   libavcodec/lagarithrac.h |  1 +
>   2 files changed, 37 insertions(+)

This adds a load of completely uncommented and confusing code; it murders
readability for... what? Making a 'timeout' in a specific fuzzer go away?

Is there a real benefit or reason to pollute the code with this? Measurable and
useful speedup?

- Derek