[FFmpeg-devel] [PATCH 2/3] flvdec: Mark the demuxer as allowing discontinuous timestamps

[Derek Buitenhuis]

On 26/11/2018 13:51, Derek Buitenhuis wrote:
> On 23/11/2018 02:16, Michael Niedermayer wrote:
>> do we have some sample flv files that require this patchset / that have
>> discontinuites.
> 
> I have many. I've mailed you one privately, while I work on getting a public one.
> 
>> another thing i just realize now, why is this discontinuity issues coming up
>> now? flv support is very old. This should be a long standing issue
> 
> Probably not many codebases check the DISCONT flag. I only just added proper
> discontinuity handling to some codebases this year, and that's why *I* noticed.
> Chances are most people use the ffmpeg cli which seems to handle stuff differently,
> and doesn't necessarily care about the flag. In my case, I only try to 'fix'
> discontinuities if they appear to be in a format that allows them, during indexing.
> 
> I could add a workaround specific to FLV, or some threshold stuff, but I'd prefer
> that demuxers which may output discontinuous timestamps say they do.

Ping. Is there a decision on eitehr what to do or to ignore this?

I'll update my downstream code with an FLV edge case if need be.

- Derek