[FFmpeg-devel] [PATCH] Add HDR dynamic metadata struct (for SMPTE 2094-40) to libavutil.

[Vittorio Giovara]

On Thu, Dec 20, 2018 at 7:18 PM Mohammad Izadi <moh.izadi at gmail.com> wrote:

> Hi Vittorio,
>
> Thank you for your feedback ! Here is my answers to your questions:
>
> I thought we were going to rename the header as dynamic_hdr.h since it may
> contain multiple variants of metadata.
> Also I believe "metadata" in the name is redundant, but won't insist too
> much if you have strong feelings for it.
> *dynamic_hdr does not really point to dynamic metadata. When we use
> dynamic_hdr, it may be interpreted as a new type of HDR. I think
> hdr_dynamic_metadata is more meaningful. *
>

ok i won't insist about this too much if you prefer


> Since these two types only apply to HDR, do you think adding HDR in their
> names, like AVHDRPlusOverlapProcessOption and AVHDRPlusPercentile, would
> make sense?
> Would make them similar to the other types below
> *Done.*
>
> maybe add "or NULL on failure." here too
> also why return type and function name on two different lines?
> *Done.*
>

cool thanks
by the way do you have commit access or would like me to push the updated
patch when you send it?
-- 
Vittorio