[FFmpeg-devel] [PATCH]lsws/utils: Split "emms_c(); " call in two lines

Carl Eugen Hoyos ceffmpeg at gmail.com
Wed Dec 19 16:55:55 EET 2018


2018-12-17 20:43 GMT+01:00, Carl Eugen Hoyos <ceffmpeg at gmail.com>:
> 2018-12-17 16:45 GMT+01:00, Nicolas George <george at nsup.org>:
>> Carl Eugen Hoyos (2018-12-17):
>>>  #ifndef emms_c
>>> -#   define emms_c() while(0)
>>> +#   define emms_c() while(0){}
>>>  #endif
>>
>> That feels really wrong, or at least completely unusual. But not the
>> change you made, the original code: the usual statement is:
>> "do { statement } while (0)"
>>
>> And if you make that change, you will get a warning about a semicolon
>> after a braced block.
>>
>> I suggest to change the definition to
>>
>> #define emms_c() do { } while (0)
>
> New patch attached.

Patch applied.

Thank you, Carl Eugen


More information about the ffmpeg-devel mailing list