[FFmpeg-devel] [PATCH] avformat/nutenc: Document trailer index assert better

Paul B Mahol onemda at gmail.com
Fri Dec 14 22:59:25 EET 2018


On 12/14/18, Michael Niedermayer <michael at niedermayer.cc> wrote:
> Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> ---
>  libavformat/nutenc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavformat/nutenc.c b/libavformat/nutenc.c
> index a92ff55c01..e9a3bb49db 100644
> --- a/libavformat/nutenc.c
> +++ b/libavformat/nutenc.c
> @@ -1172,7 +1172,7 @@ static int nut_write_trailer(AVFormatContext *s)
>
>      ret = avio_open_dyn_buf(&dyn_bc);
>      if (ret >= 0 && nut->sp_count) {
> -        av_assert1(nut->write_index);
> +        av_assert1(nut->write_index); // sp_count should be 0 if no index
> is going to be written
>          write_index(nut, dyn_bc);
>          put_packet(nut, bc, dyn_bc, 1, INDEX_STARTCODE);
>      }
> --
> 2.19.2

Yea, figured it later, patch is fine.


More information about the ffmpeg-devel mailing list