[FFmpeg-devel] [PATCH] swscale/ppc: Move VSX-using code to its own file

[Carl Eugen Hoyos]

2018-11-26 13:24 GMT+01:00, Lauri Kasanen <cand at gmx.com>:
> Passes fate on LE (with "lavc/jrevdct: Avoid an aliasing violation"
> applied). Can anyone test BE?

> diff --git a/libswscale/ppc/swscale_vsx.c b/libswscale/ppc/swscale_vsx.c
> new file mode 100644
> index 0000000..853b587
> --- /dev/null
> +++ b/libswscale/ppc/swscale_vsx.c
> @@ -0,0 +1,164 @@
> +/*
> + * AltiVec-enhanced yuv2yuvX
> + *
> + * Copyright (C) 2004 Romain Dolbeau <romain at dolbeau.org>
> + * based on the equivalent C code in swscale.c
> + *
> + * This file is part of FFmpeg.
> + *
> + * FFmpeg is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU Lesser General Public
> + * License as published by the Free Software Foundation; either
> + * version 2.1 of the License, or (at your option) any later version.
> + *
> + * FFmpeg is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> + * Lesser General Public License for more details.
> + *
> + * You should have received a copy of the GNU Lesser General Public
> + * License along with FFmpeg; if not, write to the Free Software
> + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301
> USA
> + */
> +
> +#include <inttypes.h>
> +
> +#include "config.h"
> +#include "libswscale/swscale.h"
> +#include "libswscale/swscale_internal.h"
> +#include "libavutil/attributes.h"
> +#include "libavutil/cpu.h"
> +#include "yuv2rgb_altivec.h"
> +#include "libavutil/ppc/util_altivec.h"
> +

> +#if HAVE_VSX
> +#define vzero vec_splat_s32(0)
> +
> +#if !HAVE_BIGENDIAN

I changed these two if's and the ones on the bottom of the file into "if 1"
and tested on Power7 Linux BE, fate passes (and fails if I break the
function).
Problem is that HAVE_VSX is 0 on that system. How can this be fixed?

Carl Eugen