[FFmpeg-devel] [PATCH v2] avcodec/mips: [loongson] reoptimize h264_chroma_mc8_mmi v2.

Michael Niedermayer michael at niedermayer.cc
Fri Aug 31 14:03:14 EEST 2018


On Fri, Aug 31, 2018 at 10:30:21AM +0800, Shiyou Yin wrote:
> >-----Original Message-----
> >From: ffmpeg-devel-bounces at ffmpeg.org [mailto:ffmpeg-devel-bounces at ffmpeg.org] On Behalf Of
> >Michael Niedermayer
> >Sent: Friday, August 31, 2018 5:47 AM
> >To: FFmpeg development discussions and patches
> >Subject: Re: [FFmpeg-devel] [PATCH v2] avcodec/mips: [loongson] reoptimize h264_chroma_mc8_mmi v2.
> >
> >On Thu, Aug 30, 2018 at 02:24:04PM +0800, Shiyou Yin wrote:
> >> Reoptimize function ff_put_h264_chroma_mc8_mmi and ff_avg_h264_chroma_mc8_mmi.
> >> Performance of h264 decoding improved about 5%(from 69fps to 73fps, tested on loongson 3A3000).
> >
> >what do you mean by "Reoptimize"?
> >does this port some optimizations from elsewhere ?
> >does this take the same code as previous optimizations did and re implements
> >(better/faster) MIPS code based on it ?
> >
> >what is the speed difference ?
> 
> Two functions have optimized with mmi yet.
> This patch was based on the previous version, then optimized the branch condition and the code in
> branch.
> This patch will speed up about 5% for h264 decode on loongson platform.
> 

> >>
> >> Change-Id: Iccd7f4e480b2d0bfc47e4d409874c4adb77416cc
> >
> >what is this ?
> 
> The original patch was made from loongson's local repository(we use gerrit to manage patch review
> and merge), each commit has it's own Change-Id.
> When I use git am to apply this patch to ffmpeg source, so the Change-Id was keeped with commit
> message.
> I will remove it in the next version.

you can use git notes to keep track of internal change-ids but they
should not be in public commits as noone can do anything with them except you.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I am the wisest man alive, for I know one thing, and that is that I know
nothing. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180831/7721dd8d/attachment.sig>


More information about the ffmpeg-devel mailing list