[FFmpeg-devel] [PATCH] fate: add 10-bit test for hue video filter

Michael Niedermayer michael at niedermayer.cc
Thu Aug 30 01:26:11 EEST 2018


On Tue, Aug 28, 2018 at 01:16:03PM +0200, Tobias Rapp wrote:
> Signed-off-by: Tobias Rapp <t.rapp at noa-archive.com>
> ---
>  tests/fate/filter-video.mak | 3 +++
>  tests/ref/fate/filter-hue4  | 1 +
>  2 files changed, 4 insertions(+)
>  create mode 100644 tests/ref/fate/filter-hue4
> 
> diff --git a/tests/fate/filter-video.mak b/tests/fate/filter-video.mak
> index edd51e1..c87a7ba 100644
> --- a/tests/fate/filter-video.mak
> +++ b/tests/fate/filter-video.mak
> @@ -514,6 +514,9 @@ fate-filter-hue2: CMD = video_filter "perms=random,hue=h=18*n" -frames:v 20
>  FATE_FILTER_VSYNTH-$(call ALLYES, PERMS_FILTER HUE_FILTER) += fate-filter-hue3
>  fate-filter-hue3: CMD = video_filter "perms=random,hue=b=n-10" -frames:v 20
>  
> +FATE_FILTER_VSYNTH-$(call ALLYES, FORMAT_FILTER PERMS_FILTER HUE_FILTER) += fate-filter-hue4
> +fate-filter-hue4: CMD = video_filter "format=yuv422p10,perms=random,hue=h=18*n:s=n/10" -frames:v 20
> +
>  FATE_FILTER_VSYNTH-$(CONFIG_IDET_FILTER) += fate-filter-idet
>  fate-filter-idet: CMD = framecrc -flags bitexact -idct simple -i $(SRC) -vf idet -frames:v 25 -flags +bitexact
>  
> diff --git a/tests/ref/fate/filter-hue4 b/tests/ref/fate/filter-hue4
> new file mode 100644
> index 0000000..2a08c33
> --- /dev/null
> +++ b/tests/ref/fate/filter-hue4
> @@ -0,0 +1 @@
> +hue4                6279ed43527e7b5be645819e08880107

fails on mips as that uses a big endian output format instead with
different md5

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180830/2f5425f9/attachment.sig>


More information about the ffmpeg-devel mailing list