[FFmpeg-devel] [PATCH] avformat/utils: Don't parse encrypted packets.

[Michael Niedermayer]

On Tue, Aug 28, 2018 at 10:58:43AM -0700, Jacob Trimble wrote:
> If a packet is full-sample encrypted, then packet data can't be parsed
> without decrypting it.  So this skips the packet parsing for those
> packets.  If the packet has sub-sample encryption, it is assumed that
> the headers are in the clear and the parser will only need that info.
> 
> Signed-off-by: Jacob Trimble <modmaker at google.com>
> ---
>  libavformat/utils.c | 21 ++++++++++++++++++++-
>  1 file changed, 20 insertions(+), 1 deletion(-)

Hmm, please correct me if iam wrong but IIUC
1. The demuxer has set need_parsing, indicating that it _requires_ a parser
2. Parsing cannot be done before decrypting

If all this and the set values are correct, logically, the fix would be
to decrypt the packet before the parser not to skip the parser.

Am i missing something ?

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

"I am not trying to be anyone's saviour, I'm trying to think about the
 future and not be sad" - Elon Musk

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180830/ef928eff/attachment.sig>