[FFmpeg-devel] Correct opus-in-mp4 pre-skip to be uint16_t versus int16_t.

Michael Niedermayer michael at niedermayer.cc
Thu Aug 23 15:18:49 EEST 2018


On Wed, Aug 22, 2018 at 12:58:13AM -0300, James Almer wrote:
> On 8/21/2018 7:45 PM, Dale Curtis wrote:
> > This field is a uint16_t, see docs:
> > http://opus-codec.org/docs/opus_in_isobmff.html#4.3.2
> > 
> > Signed-off-by: Dale Curtis <dalecurtis at chromium.org>
> > 
> > 
> > 0001-Correct-opus-in-mp4-pre-skip-to-be-uint16_t-versus-i.patch
> > 
> > 
> > From 7f1588bc92ef4a70025aa140a8e660a36875c89c Mon Sep 17 00:00:00 2001
> > From: Dale Curtis <dalecurtis at chromium.org>
> > Date: Tue, 21 Aug 2018 15:42:31 -0700
> > Subject: [PATCH] Correct opus-in-mp4 pre-skip to be uint16_t versus int16_t.
> > 
> > This field is a uint16_t, see docs:
> > http://opus-codec.org/docs/opus_in_isobmff.html#4.3.2
> > 
> > Signed-off-by: Dale Curtis <dalecurtis at chromium.org>
> > ---
> >  libavformat/mov.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/libavformat/mov.c b/libavformat/mov.c
> > index 1bd7d7e483..02f6c1e0a1 100644
> > --- a/libavformat/mov.c
> > +++ b/libavformat/mov.c
> > @@ -6608,7 +6608,7 @@ static int mov_read_dops(MOVContext *c, AVIOContext *pb, MOVAtom atom)
> >      const int OPUS_SEEK_PREROLL_MS = 80;
> >      AVStream *st;
> >      size_t size;
> > -    int16_t pre_skip;
> > +    uint16_t pre_skip;
> >  
> >      if (c->fc->nb_streams < 1)
> >          return 0;
> > -- 2.18.0.1017.ga543ac7ca45-goog
> 
> Should be ok.

will apply

thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many that live deserve death. And some that die deserve life. Can you give
it to them? Then do not be too eager to deal out death in judgement. For
even the very wise cannot see all ends. -- Gandalf
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180823/91378ff6/attachment.sig>


More information about the ffmpeg-devel mailing list