[FFmpeg-devel] [PATCH] configure: do not add --fsanitize= if coverage is tested

[Michael Niedermayer]

On Mon, Aug 20, 2018 at 10:55:00AM -0300, James Almer wrote:
> On 8/19/2018 5:40 PM, Michael Niedermayer wrote:
> > Found-by: Max Moroz
> > Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> > ---
> >  configure | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/configure b/configure
> > index 9b5421d5a8..b9c9d0b307 100755
> > --- a/configure
> > +++ b/configure
> > @@ -3964,7 +3964,7 @@ set >> $logfile
> >  
> >  test -n "$valgrind" && toolchain="valgrind-memcheck"
> >  
> > -enabled ossfuzz && ! echo $CFLAGS | grep -q -- "-fsanitize="  &&{
> > +enabled ossfuzz && ! echo $CFLAGS | grep -q -- "-fsanitize="  && ! echo $CFLAGS | grep -q -- "-fcoverage-mapping" &&{
> 
> What part of configure adds -fcoverage-mapping? Or is this looking for a
> user set cflag?

user cflags


> 
> The subject should be more specific. This is specific for ossfuzz, not
> other toolchains that add -fsanitize like asan/usan.

what do you suggest ?

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The smallest minority on earth is the individual. Those who deny 
individual rights cannot claim to be defenders of minorities. - Ayn Rand
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180821/25596e2a/attachment.sig>