[FFmpeg-devel] [PATCH] avs2: Correct expression error and simplify log

James Almer jamrial at gmail.com
Tue Aug 7 06:07:26 EEST 2018


On 8/6/2018 8:34 PM, Huiwen Ren wrote:
> 
> 在 2018-08-07 02:09:34,"James Almer" <jamrial at gmail.com> 写道:
>> On 8/6/2018 11:21 AM, Gyan Doshi wrote:
>>>
>>>
>>> On 06-08-2018 07:13 PM, hwren wrote:
>>>
>>>> -    .long_name      = NULL_IF_CONFIG_SMALL("Decoder for AVS2/IEEE
>>>> 1857.4"),
>>>> +    .long_name      = NULL_IF_CONFIG_SMALL("Decoder for
>>>> AVS2-P2/IEEE1857.4"),
>>>
>>> "Decoder for" is not needed. The flag indicates its role in `ffmpeg
>>> -codecs`.
>>
>> The correct string considering this is a decoder using an external
>> library would be something like "libdavs2 AVS2-P2/IEEE1857.4"
> 
> "AVS2-P2/IEEE1857.4 external decoder wrapper"?

No, look at libopenh264dec.c, libvpxdec.c, etc. They all have a
long_name field listing the name of the external library followed by the
codec they support.

OpenH264 H.264 / AVC / MPEG-4 AVC / MPEG-4 part 10
libvpx VP9
libaom AV1
Fraunhofer FDK AAC
libopus Opus

So "libdavs2 AVS2-P2/IEEE1857.4" would be the correct string here.


More information about the ffmpeg-devel mailing list