[FFmpeg-devel] [PATCH] avformat/tls_schannel: Fix use of uninitialized variable

[Carl Eugen Hoyos]

2018-08-02 20:46 GMT+02:00, Paweł Wegner <pawel.wegner95 at gmail.com>:
> Fixes: runtime error: passing uninitialized value to FreeContextBuffer
> causes a crash
> ---
>  libavformat/tls_schannel.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/libavformat/tls_schannel.c b/libavformat/tls_schannel.c
> index 065dccb..6953008 100644
> --- a/libavformat/tls_schannel.c
> +++ b/libavformat/tls_schannel.c
> @@ -154,6 +154,8 @@ static int tls_client_handshake_loop(URLContext *h, int
> initial)
>      SecBufferDesc inbuf_desc;
>      int i, ret = 0, read_data = initial;
>
> +    memset(outbuf, 0, sizeof(outbuf));

Is the memset necessary or is an initialization of the variable sufficient?

Carl Eugen